Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize camel and camel-quarkus dependencies #2170

Closed
nicolaferraro opened this issue Mar 24, 2021 · 2 comments · Fixed by #2208
Closed

Normalize camel and camel-quarkus dependencies #2170

nicolaferraro opened this issue Mar 24, 2021 · 2 comments · Fixed by #2208
Labels
area/core Core features of the integration platform area/runtime

Comments

@nicolaferraro
Copy link
Member

Let's take a hello world integration. There are some commands that theoretically should do the same thing, but they don't:

  • kamel run hello.yaml -d camel:jackson: adds org.apache.camel:camel-jackson
  • kamel run hello.yaml -d camel-quarkus:jackson: error in the CLI, but works as next one if set manually in the integration
  • kamel run hello.yaml -d camel-quarkus-jackson: adds org.apache.camel.quarkus:camel-quarkus-jackson and transitively org.apache.camel:camel-jackson

I think that we should treat camel: and camel-quarkus: as synonyms, as there's no reason why one would like to add the camel component without the quarkus extension, given that we only have quarkus as runtime. People can still use mvn: if they want to use a specific lib. We can keep both for compatibility, but with the same meaning.

This problem is also evident in Kamelets, where we need to use camel-quarkus: and mark the Kamelet as requiring Quarkus just because dependency formats are distinct.

cc @astefanutti , @lburgazzoli wdyt?

@astefanutti
Copy link
Member

astefanutti commented Mar 24, 2021

Totally makes sense. Considering the runtime as an implementation detail, that should not resurface to the end-users as much as possible, camel-quarkus should ideally be dropped and only camel: be kept. We can keep it around for backward compatibility reason, but have it replaced all around. Also, maybe we can go a step further and shorten camel:aws2-sqs with just aws2-sqs.

@astefanutti astefanutti added area/core Core features of the integration platform area/runtime and removed area/core Core features of the integration platform labels Mar 24, 2021
@lburgazzoli
Copy link
Contributor

On the subject I've opened an issue on camel-quarkus as we can certainly have some way to detect and support both camel-quarkus- vs camel- or even a shorter form, but for a safer approach would be to add such info in the catalog and do not rely on duck typing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Core features of the integration platform area/runtime
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants