Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to latest golangci-lint #2333

Closed
lburgazzoli opened this issue May 27, 2021 · 2 comments · Fixed by #2714
Closed

build: update to latest golangci-lint #2333

lburgazzoli opened this issue May 27, 2021 · 2 comments · Fixed by #2714
Assignees
@tadayosi
Labels
area/continuous integration Related to CI and automated testing

Comments

@lburgazzoli
Copy link
Contributor

We are using v1.20.1 but the latest release is 1.40.1.
Running the latest released reveal a number of new issues, we should check if they make sense
@astefanutti astefanutti added area/continuous integration Related to CI and automated testing and removed area/ci labels Jun 2, 2021
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@tadayosi tadayosi self-assigned this Oct 21, 2021
@tadayosi
Copy link
Member

Let me take a look.

tadayosi added a commit to tadayosi/camel-k that referenced this issue Oct 25, 2021
@tadayosi
fix(lint): fix lint from updated golangci-lint
409042d 
* Change linters to allowlist approach (disable-all: true) to make
  future golangci-lint upgrades easier as otherwise unexpected linter
  might be included upon upgrade.

Fix apache#2333 apache#2334
@tadayosi tadayosi mentioned this issue Oct 25, 2021
Merged
tadayosi added a commit to tadayosi/camel-k that referenced this issue Oct 25, 2021
@tadayosi
fix(lint): fix lint from updated golangci-lint
d210185 
* Change linters to allowlist approach (disable-all: true) to make
  future golangci-lint upgrades easier as otherwise unexpected linter
  might be included upon upgrade.

Fix apache#2333 apache#2334
tadayosi added a commit to tadayosi/camel-k that referenced this issue Oct 26, 2021
@tadayosi
fix(lint): fix lint from updated golangci-lint
7fb527e 
* Change linters to allowlist approach (disable-all: true) to make
  future golangci-lint upgrades easier as otherwise unexpected linter
  might be included upon upgrade.

Fix apache#2333 apache#2334
tadayosi added a commit that referenced this issue Oct 27, 2021
@tadayosi
fix(lint): fix lint from updated golangci-lint
38fd847 
* Change linters to allowlist approach (disable-all: true) to make
  future golangci-lint upgrades easier as otherwise unexpected linter
  might be included upon upgrade.

Fix #2333 #2334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadayosi tadayosi

Labels
area/continuous integration Related to CI and automated testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): update to golangci-lint 1.42.x and use golangci/golangci-lint-action tadayosi/camel-k
3 participants
@tadayosi @astefanutti @lburgazzoli