Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder/Camel trait configmap/secret beside properties #3002

Closed
squakez opened this issue Feb 10, 2022 · 4 comments · Fixed by #3626
Closed

Builder/Camel trait configmap/secret beside properties #3002

squakez opened this issue Feb 10, 2022 · 4 comments · Fixed by #3626
Assignees
@essobedo
Labels
good first issue Does not require full understanding of the codebase kind/feature New feature or request status/never-stale

Comments

@squakez
Copy link
Contributor

squakez commented Feb 10, 2022

The builder trait allow you to define plain text properties that will be provided at build time. This is also available via

kamel run --build-property a=1

It would be nice to provide the possibility to use configmap and secret as well in order to have something like:

kamel run --build-properties secret:my-build-props

The same may be applied to camel trait which exposes runtime properties
@squakez squakez added kind/feature New feature or request good first issue Does not require full understanding of the codebase labels Feb 10, 2022
@mmelko
Copy link
Contributor

mmelko commented Mar 23, 2022

I can look at this

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@essobedo
Copy link
Contributor

essobedo commented Sep 8, 2022

@mmelko are you still working on this issue?

@mmelko mmelko removed their assignment Sep 9, 2022
@essobedo essobedo mentioned this issue Sep 9, 2022
Merged
@essobedo
Copy link
Contributor

essobedo commented Sep 9, 2022

Should be fixed by #3626

essobedo added a commit that referenced this issue Sep 13, 2022
@essobedo
feat(cmd/run): secret/configmap as runtime/build-time properties (#3626)
6e6aff2 
fixes #3002

## Motivation:

It would be nice to provide the possibility to use configmap and secret as runtime or build-time properties for the camel and builder traits.

## Modifications:

* Add the support of `configmap:name-of-configmap` and `secret:name-of-secret` to the flags `property` and `build-property`
* Move the functions `extractProperties` and `mergePropertiesWithPrecedence` from `run_help.go` to `run.go` as we need to add a receiver
* Move the unit tests of the functions moved to the corresponding test file
* Add related E2E test
* Add related doc
squakez pushed a commit to squakez/camel-k that referenced this issue Sep 13, 2022
@essobedo @github-actions
feat(cmd/run): secret/configmap as runtime/build-time properties (apa…
5ce5de3 
…che#3626)

fixes apache#3002

## Motivation:

It would be nice to provide the possibility to use configmap and secret as runtime or build-time properties for the camel and builder traits.

## Modifications:

* Add the support of `configmap:name-of-configmap` and `secret:name-of-secret` to the flags `property` and `build-property`
* Move the functions `extractProperties` and `mergePropertiesWithPrecedence` from `run_help.go` to `run.go` as we need to add a receiver
* Move the unit tests of the functions moved to the corresponding test file
* Add related E2E test
* Add related doc

(cherry picked from commit apache/camel-k@6e6aff2e7)
squakez pushed a commit to squakez/camel-k that referenced this issue Sep 13, 2022
@essobedo @github-actions
feat(cmd/run): secret/configmap as runtime/build-time properties (apa…
2b20458 
…che#3626)

fixes apache#3002

## Motivation:

It would be nice to provide the possibility to use configmap and secret as runtime or build-time properties for the camel and builder traits.

## Modifications:

* Add the support of `configmap:name-of-configmap` and `secret:name-of-secret` to the flags `property` and `build-property`
* Move the functions `extractProperties` and `mergePropertiesWithPrecedence` from `run_help.go` to `run.go` as we need to add a receiver
* Move the unit tests of the functions moved to the corresponding test file
* Add related E2E test
* Add related doc

(cherry picked from commit apache/camel-k@6e6aff2e7)
squakez pushed a commit to squakez/camel-k that referenced this issue Sep 13, 2022
@essobedo @github-actions
feat(cmd/run): secret/configmap as runtime/build-time properties (apa…
4d38c86 
…che#3626)

fixes apache#3002

## Motivation:

It would be nice to provide the possibility to use configmap and secret as runtime or build-time properties for the camel and builder traits.

## Modifications:

* Add the support of `configmap:name-of-configmap` and `secret:name-of-secret` to the flags `property` and `build-property`
* Move the functions `extractProperties` and `mergePropertiesWithPrecedence` from `run_help.go` to `run.go` as we need to add a receiver
* Move the unit tests of the functions moved to the corresponding test file
* Add related E2E test
* Add related doc

(cherry picked from commit apache/camel-k@6e6aff2e7)
squakez pushed a commit to squakez/camel-k that referenced this issue Sep 14, 2022
@essobedo @github-actions
feat(cmd/run): secret/configmap as runtime/build-time properties (apa…
9f93051 
…che#3626)

fixes apache#3002

## Motivation:

It would be nice to provide the possibility to use configmap and secret as runtime or build-time properties for the camel and builder traits.

## Modifications:

* Add the support of `configmap:name-of-configmap` and `secret:name-of-secret` to the flags `property` and `build-property`
* Move the functions `extractProperties` and `mergePropertiesWithPrecedence` from `run_help.go` to `run.go` as we need to add a receiver
* Move the unit tests of the functions moved to the corresponding test file
* Add related E2E test
* Add related doc

(cherry picked from commit apache/camel-k@6e6aff2e7)
squakez pushed a commit to squakez/camel-k that referenced this issue Sep 14, 2022
@essobedo @github-actions
feat(cmd/run): secret/configmap as runtime/build-time properties (apa…
87237b2 
…che#3626)

fixes apache#3002

## Motivation:

It would be nice to provide the possibility to use configmap and secret as runtime or build-time properties for the camel and builder traits.

## Modifications:

* Add the support of `configmap:name-of-configmap` and `secret:name-of-secret` to the flags `property` and `build-property`
* Move the functions `extractProperties` and `mergePropertiesWithPrecedence` from `run_help.go` to `run.go` as we need to add a receiver
* Move the unit tests of the functions moved to the corresponding test file
* Add related E2E test
* Add related doc

(cherry picked from commit apache/camel-k@6e6aff2e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@essobedo essobedo

Labels
good first issue Does not require full understanding of the codebase kind/feature New feature or request status/never-stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cmd/run): secret/configmap as runtime/build-time properties apache/camel-k
3 participants
@essobedo @mmelko @squakez