Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kaniko settings refactoring #3005

Closed
squakez opened this issue Feb 10, 2022 · 1 comment · Fixed by #3032
Closed

Kaniko settings refactoring #3005

squakez opened this issue Feb 10, 2022 · 1 comment · Fixed by #3032
Assignees
@mmelko
Labels
area/core Core features of the integration platform good first issue Does not require full understanding of the codebase

Comments

@squakez
Copy link
Contributor

squakez commented Feb 10, 2022

We are declaring certain specific configuration required for Kaniko directly in the IntegrationPlatformBuildSpec [1] and [2]. We should not let this details slip in the general configuration. A possible alternative is to provide a PublishStrategyOptions parameter with an open array/map of parameters that can be required by the strategy used (and where to move the aforementioned Kaniko parameters).

[1] https://github.com/apache/camel-k/blob/main/pkg/apis/camel/v1/integrationplatform_types.go#L117
[2] https://github.com/apache/camel-k/blob/main/pkg/apis/camel/v1/integrationplatform_types.go#L119
@squakez squakez added area/core Core features of the integration platform good first issue Does not require full understanding of the codebase labels Feb 10, 2022
@mmelko
Copy link
Contributor

mmelko commented Feb 15, 2022

I will look at this one.

@squakez squakez assigned squakez and mmelko and unassigned squakez Feb 15, 2022
mmelko added a commit to mmelko/camel-k that referenced this issue Feb 22, 2022
@mmelko
Refactor Kaniko settings
21b2b41 
fix apache#3005
mmelko added a commit to mmelko/camel-k that referenced this issue Feb 23, 2022
@mmelko
Move kaniko related settings to map
fc2489d 
fix apache#3005
mmelko added a commit to mmelko/camel-k that referenced this issue Feb 23, 2022
@mmelko
Refactor kaniko settings
0724a18 
fix apache#3005
@mmelko mmelko mentioned this issue Feb 23, 2022
Merged
mmelko added a commit to mmelko/camel-k that referenced this issue Feb 24, 2022
@mmelko
Refactor kaniko settings
153f805 
fix apache#3005
mmelko added a commit to mmelko/camel-k that referenced this issue Feb 25, 2022
@mmelko
Refactor kaniko settings
b889082 
fix apache#3005
mmelko added a commit to mmelko/camel-k that referenced this issue Feb 28, 2022
@mmelko
Refactor kaniko settings
8f79f9f 
fix apache#3005
mmelko added a commit to mmelko/camel-k that referenced this issue Mar 9, 2022
@mmelko
Refactor kaniko settings
ca9b8b2 
fix apache#3005
squakez pushed a commit that referenced this issue Mar 11, 2022
@mmelko @squakez
Refactor kaniko settings
a79f832 
fix #3005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmelko mmelko

Labels
area/core Core features of the integration platform good first issue Does not require full understanding of the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor kaniko settings mmelko/camel-k
2 participants
@mmelko @squakez