Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kamel run -o incompatible with --dev #3195

Closed
squakez opened this issue Apr 12, 2022 · 4 comments · Fixed by #3219
Closed

Kamel run -o incompatible with --dev #3195

squakez opened this issue Apr 12, 2022 · 4 comments · Fixed by #3219
Assignees
Labels
area/cli Kamel CLI good first issue Does not require full understanding of the codebase kind/bug Something isn't working

Comments

@squakez
Copy link
Contributor

squakez commented Apr 12, 2022

Running

kamel run ./examples/languages/Sample.java --dev -o yaml

Will produce an error like

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x1d9b80f]

goroutine 1 [running]:
github.com/apache/camel-k/pkg/util/watch.HandleIntegrationStateChanges(0x2748458, 0xc000064280, 0x27829a0, 0xc0007f86c0, 0x0, 0xc000bb34c8, 0x0, 0x0, 0x0)
	github.com/apache/camel-k/pkg/util/watch/watch.go:35 +0x8f
github.com/apache/camel-k/pkg/cmd.(*runCmdOptions).waitForIntegrationReady(0xc000af0e00, 0xc00081b900, 0x27829a0, 0xc0007f86c0, 0x0, 0xc0007f86c0, 0x0, 0xc000848010)
	github.com/apache/camel-k/pkg/cmd/run.go:416 +0x9e
github.com/apache/camel-k/pkg/cmd.(*runCmdOptions).run(0xc000af0e00, 0xc00081b900, 0xc00044b2c0, 0x1, 0x4, 0x0, 0x0)
	github.com/apache/camel-k/pkg/cmd/run.go:343 +0x4be
github.com/spf13/cobra.(*Command).execute(0xc00081b900, 0xc00044b280, 0x4, 0x4, 0xc00081b900, 0xc00044b280)
	github.com/spf13/cobra@v1.2.1/command.go:856 +0x472
github.com/spf13/cobra.(*Command).ExecuteC(0xc00081ac80, 0xc0007f9b80, 0xc00004c1e0, 0x6)
	github.com/spf13/cobra@v1.2.1/command.go:974 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.2.1/command.go:902
main.main()
	github.com/apache/camel-k/cmd/kamel/main.go:47 +0x17d

We probably need to include a check to warn the user the two options are not compatible.

@squakez squakez added kind/bug Something isn't working good first issue Does not require full understanding of the codebase area/cli Kamel CLI labels Apr 12, 2022
@KuthumiPepple
Copy link
Contributor

I'd like to be assigned this issue

@KuthumiPepple
Copy link
Contributor

Hi, just wanted to check if this PR is ok to be merged or if there are more things to be done.

@squakez
Copy link
Contributor Author

squakez commented Apr 20, 2022

Yeah, it's good to go. Let's give the previous failing test another chance and then we can get it merged, thanks!

@oscerd
Copy link
Contributor

oscerd commented Apr 20, 2022

I'm going to release 1.9.0 tomorrow, so eventually I could merge this immediately before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Kamel CLI good first issue Does not require full understanding of the codebase kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants