fix: kamel run -o incompatible with --dev #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squakez
reviewed
Apr 18, 2022
pkg/cmd/run.go
Outdated
| @@ -243,6 +243,10 @@ func (o *runCmdOptions) validate() error { | |||
| return err | |||
| } | |||
|
|
|||
| if o.OutputFormat != "" && o.Dev { | |||
| return errors.New("option '-o' is not compatible with '--dev'") | |||
There was a problem hiding this comment.
We better keep using the fmt package as we're doing for the rest of errors, ie return fmt.Errorf(invalid label specification %s. Expected "<labelkey>=<labelvalue>", label)
There was a problem hiding this comment.
Ok I'd use the fmt package
|
I have implemented the change |
squakez
reviewed
Apr 19, 2022
pkg/cmd/run.go
Outdated
| @@ -243,6 +243,10 @@ func (o *runCmdOptions) validate() error { | |||
| return err | |||
| } | |||
|
|
|||
| if o.OutputFormat != "" && o.Dev { | |||
| return fmt.Errorf(`invalid dev specification "%t". Expected "--dev=false"`, o.Dev) | |||
There was a problem hiding this comment.
I think it won't be clear for the user why this is invalid. I guess something like cannot use --dev with -o/--output options would be clearer.
There was a problem hiding this comment.
Thanks, I'll amend and force push
KuthumiPepple
force-pushed
the
Issue-3195-cli-run
branch
from
d433e5e
to
612dac3
Compare
squakez
approved these changes
Apr 19, 2022
oscerd
approved these changes
Apr 20, 2022
|
Please rebase on main, so it will be aligned and test will pass. |
KuthumiPepple
force-pushed
the
Issue-3195-cli-run
branch
from
612dac3
to
12f1d58
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3195
@astefanutti @squakez I included a test first for the fix. For the fix, I added a check for both flags. If both flags are present, an error is returned with the error message written to the error writer. Please review and let me know if there are any more things I could do.
Release Note