Release 1.9.0 - Failure to install via OLM

[phantomjinx]

I came across this yesterday while using 1.9.1-SNAPSHOT but now found it also to be the case in the released 1.9.0.

Running kamel install .... from the CLI against OCP4, using OLM, the operator crashes while trying to create a subscription.

kamel-1.9.0 install -n test-3d212af8-dedc-4ecc-9b05-c6f86a3ca0fe --olm=true --olm-source test-camel-k-source --olm-source-namespace test-3d212af8-dedc-4ecc-9b05-c6f86a3ca0fe --olm-channel stable-1.9OLM is available in the cluster
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x1e5b18b]

goroutine 1 [running]:
github.com/apache/camel-k/pkg/util/olm.maybeSetTolerations(0xc0002fa1c0, 0x3949b30, 0x0, 0x0, 0x7ffcfc663992, 0x29)
        github.com/apache/camel-k/pkg/util/olm/operator.go:238 +0x8b
github.com/apache/camel-k/pkg/util/olm.Install(0x2860358, 0xc00045bf00, 0x28a1e00, 0xc00045b380, 0x7ffcfc663992, 0x29, 0x0, 0x24e63f3, 0x7, 0x24e63f3, ...)
        github.com/apache/camel-k/pkg/util/olm/operator.go:182 +0x3ed
github.com/apache/camel-k/pkg/cmd.(*installCmdOptions).install(0xc00023c2c0, 0xc000452000, 0xc00091c360, 0x0, 0x9, 0x0, 0x0)
        github.com/apache/camel-k/pkg/cmd/install.go:249 +0x2745
github.com/apache/camel-k/pkg/cmd.newCmdInstall.func1(0xc000452000, 0xc00091c360, 0x0, 0x9, 0x0, 0x0)
        github.com/apache/camel-k/pkg/cmd/install.go:71 +0xa7
github.com/spf13/cobra.(*Command).execute(0xc000452000, 0xc00091c2d0, 0x9, 0x9, 0xc000452000, 0xc00091c2d0)
        github.com/spf13/cobra@v1.4.0/command.go:856 +0x472
github.com/spf13/cobra.(*Command).ExecuteC(0xc0001e5b80, 0xc00045bec0, 0xc00004c0b0, 0xb)
        github.com/spf13/cobra@v1.4.0/command.go:974 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
        github.com/spf13/cobra@v1.4.0/command.go:902
main.main()
        github.com/apache/camel-k/cmd/kamel/main.go:47 +0x17d

The error comes from a Config struct not being included in the parent Subscription struct. Now this has been the case for some time but now seems to become a thing. I though it might just disappear but now happens repeatedly.

I have include the fix in a commit in PR #3245 but that will not fix it in the release. I wonder if a respin of 1.9.0 is required? Can anyone confirm this happening?

[oscerd]

We could release again. It shouldn't be a problem. I personally didn't reproduce this before releasing. Btw thanks for reporting and fixing. I'm going to release again beginning of next week probably on May 3.

[oscerd]

Let me know if we have all in place for 1.9.1 or if we want to wait.

[oscerd]

Any feedback?

[squakez]

Hi @oscerd , I haven't looked at this, hopefully @phantomjinx did. In general I noticed we have some test failing as well in 1.9.x and I was planning to have a look as soon as possible. I will let you know once I find something on that side.

[oscerd]

Ok, i just need green light to release 1.9.1. i'm planning to release a fixed kamelet catalog too. There is an issue with Kinesis source

[phantomjinx]

Running my er branch with the fixes from #3245, the e2e tests runs again. However, am seeing the same error that @rhuss witnessed. If that has been fixed then looking better on my end.

https://github.com/openshift-integration/camel-k-testing-ocp4/runs/6289133295?check_suite_focus=true#step:8:1873

[squakez]

@phantomjinx those errors will be fixed by #3256

[tadayosi]

Should be fixed already.