Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Service to be exposed as NodePort should be disabled by default #3253

Closed
rhtevan opened this issue May 4, 2022 · 1 comment · Fixed by #3263
Closed

Enable Service to be exposed as NodePort should be disabled by default #3253

rhtevan opened this issue May 4, 2022 · 1 comment · Fixed by #3263
Assignees

Comments

@rhtevan
Copy link

rhtevan commented May 4, 2022

The --trait service.node-port is set to true by default. Given that node port is rarely used in OpenShift or Kubernetes these days for http services, would it not make more sense to default this to ClusterIP? Customers are typically pretty sensitive about opening ports directly to the cluster.

@agahchen
Copy link

agahchen commented May 4, 2022

Thank you for raising this issue @rhtevan . We were surprised to discover this through a separate QA process by our OpenShift cluster operations team recently as they scan for potential network vulnerabilities and unintended exposures. Setting --trait service.node-port=false reverts the service type to ClusterIP. It would be ideal to apply the 'deny-by-default' approach and create node port-based service objects if explicitly requested.

@tadayosi tadayosi self-assigned this May 11, 2022
tadayosi added a commit to tadayosi/camel-k that referenced this issue May 11, 2022
tadayosi added a commit to tadayosi/camel-k that referenced this issue May 11, 2022
tadayosi added a commit to tadayosi/camel-k that referenced this issue May 25, 2022
squakez pushed a commit to jboss-fuse/camel-k that referenced this issue May 31, 2022
squakez pushed a commit to jboss-fuse/camel-k that referenced this issue May 31, 2022
squakez pushed a commit to jboss-fuse/camel-k that referenced this issue May 31, 2022
squakez pushed a commit to jboss-fuse/camel-k that referenced this issue May 31, 2022
squakez pushed a commit to jboss-fuse/camel-k that referenced this issue Jun 1, 2022
phantomjinx pushed a commit to phantomjinx/camel-k that referenced this issue Aug 11, 2022
squakez pushed a commit to jboss-fuse/camel-k that referenced this issue Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants