Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Dependencies Registry Problem #3271

Closed
jonathan-k4 opened this issue May 13, 2022 · 2 comments · Fixed by #3278
Closed

Local Dependencies Registry Problem #3271

jonathan-k4 opened this issue May 13, 2022 · 2 comments · Fixed by #3278

Comments

@jonathan-k4
Copy link

It appears the new support for local file:// dependencies ignores the organization field of the registry settings when it tries to upload the jar file to the registry.

https://camel.apache.org/camel-k/1.8.x/installation/registry/registry.html

When the integration is saved to the registry it does this:

return e.Platform.Status.Build.Registry.Address + "/" + organization + "/camel-k-" + e.IntegrationKit.Name + ":" + e.IntegrationKit.ResourceVersion

However, when the file is uploaded, it only uses registry.address:

options.Target = fmt.Sprintf("%s/%s:%s", platform.Spec.Build.Registry.Address, artifactHTTPPath, dependency.Version)

This is causing issues with uploads to Harbor as it returns a 400 because the organization in the path is missing.

johnpoth added a commit to johnpoth/camel-k that referenced this issue May 16, 2022
…oading to the image registry from the command line
johnpoth added a commit to johnpoth/camel-k that referenced this issue May 16, 2022
…oading to the image registry from the command line
@johnpoth
Copy link
Member

Thanks @jonathan-k4 for the detailed report! should be fixed with #3278, thanks!

johnpoth added a commit to johnpoth/camel-k that referenced this issue May 16, 2022
…oading to the image registry from the command line
johnpoth added a commit that referenced this issue May 17, 2022
… to the image registry from the command line
johnpoth added a commit to johnpoth/camel-k that referenced this issue May 17, 2022
…oading to the image registry from the command line

(cherry picked from commit 85bda43)
oscerd pushed a commit that referenced this issue May 17, 2022
… to the image registry from the command line

(cherry picked from commit 85bda43)
@johnpoth
Copy link
Member

Should be fixed in 1.9.2 (under vote)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants