Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make bundle adds duplicate replaces to Camel K CSV #3321

Closed
tadayosi opened this issue Jun 1, 2022 · 3 comments
Closed

make bundle adds duplicate replaces to Camel K CSV #3321

tadayosi opened this issue Jun 1, 2022 · 3 comments
Labels
area/build-operator Related to the internal image build operator kind/bug Something isn't working

Comments

@tadayosi
Copy link
Member

tadayosi commented Jun 1, 2022 •
edited
Loading

Current Camel K CSV has duplicate replaces entries:
https://github.com/apache/camel-k/blob/main/config/manifests/bases/camel-k.clusterserviceversion.yaml

It's because of a bug in make bundle and make pre-bundle targets. When you run make pre-bundle repeatedly, it endlessly adds the repaces entry at the EOF, whereas operator-sdk inserts the same entry in alphabetical order at make bundle.

   replaces: camel-k-operator.v1.9.2
+  replaces: camel-k-operator.v1.9.2
+  replaces: camel-k-operator.v1.9.2
+  replaces: camel-k-operator.v1.9.2
+  replaces: camel-k-operator.v1.9.2
@tadayosi tadayosi added kind/bug Something isn't working area/build-operator Related to the internal image build operator labels Jun 1, 2022
@tadayosi
Copy link
Member Author

tadayosi commented Jun 1, 2022

Could you have a look at this? @phantomjinx

phantomjinx added a commit to phantomjinx/camel-k that referenced this issue Jun 8, 2022
@phantomjinx
apache#3321: Fixes pre-bundle rule in Makefile
a4e8728 
* Stops duplicate replaces lines being added.
@phantomjinx
Copy link
Contributor

phantomjinx commented Jun 8, 2022 •
edited
Loading

PR #3343

tadayosi pushed a commit that referenced this issue Jun 9, 2022
@phantomjinx @tadayosi
#3321: Fixes pre-bundle rule in Makefile
c06d258 
* Stops duplicate replaces lines being added.
@squakez
Copy link
Contributor

squakez commented Jul 13, 2022

Fixed by #3343

@squakez squakez closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build-operator Related to the internal image build operator kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tadayosi @phantomjinx @squakez