Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camel-k ignores changes to traits configured using annotations #3479

Closed
lburgazzoli opened this issue Jul 24, 2022 · 2 comments · Fixed by #3480
Closed

camel-k ignores changes to traits configured using annotations #3479

lburgazzoli opened this issue Jul 24, 2022 · 2 comments · Fixed by #3480

Comments

@lburgazzoli
Copy link
Contributor

Assuming that you have a binding like the one below were annotations are used to configure traits:

apiVersion: camel.apache.org/v1alpha1
kind: KameletBinding
metadata:
  name: timer2log
  annotations:
    trait.camel.apache.org/container.image: acme/bad:1
    trait.camel.apache.org/jvm.enabled: "false"
    trait.camel.apache.org/kamelets.enabled: "false"
spec:
  integration:
    configuration:
      - type: configmap
        value: timer2log-config
  source:
    ref:
      apiVersion: camel.apache.org/v1alpha1
      kind: Kamelet
      name: timer-source
    properties:
      message: "foo"
  sink:
    ref:
      apiVersion: camel.apache.org/v1alpha1
      kind: Kamelet
      name: log-sink

In this specific case as example, the container image that must be used to run the Integration is set set using the trait.camel.apache.org/container.image: acme/bad:1 annotation.
If you update the resource and you change only the container image, then the reconcile loop is not triggered because the kamelet binding controller take into account only the phase or the generation (which does not change when only the matadata is amended ).

Since annotation can be used to configure traits,, they should be taken into account.

lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 24, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 24, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 25, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 25, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 25, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 25, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 25, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 25, 2022
@squakez
Copy link
Contributor

squakez commented Jul 26, 2022

Duplicate of #2648

@squakez squakez marked this as a duplicate of #2648 Jul 26, 2022
@tadayosi
Copy link
Member

tadayosi commented Jul 26, 2022

Btw, while I'm not sure if it's directly related to the issue, I find another bug with kameletbindings with traits, where the traits defined on a kameletbinding is always wiped out on an integration. It's being fixed with this pull req: #3478

Specifically, this is what I try to fix there: 127460a

lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 27, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 27, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 27, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 27, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 29, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Aug 3, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Aug 3, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Aug 3, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Aug 5, 2022
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Aug 5, 2022
… on the traits configured on the KameletBinding only apache#3479
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Aug 5, 2022
… on the traits configured on the KameletBinding only apache#3479
lburgazzoli added a commit that referenced this issue Aug 5, 2022
… on the traits configured on the KameletBinding only #3479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants