Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tracing from opentracing to opentelemetry #3519

Closed
squakez opened this issue Aug 8, 2022 · 5 comments · Fixed by #3970
Closed

Move tracing from opentracing to opentelemetry #3519

squakez opened this issue Aug 8, 2022 · 5 comments · Fixed by #3970
Labels

Comments

@squakez
Copy link
Contributor

squakez commented Aug 8, 2022

As Opentracing is marked as deprecated in Camel Quarkus: https://camel.apache.org/camel-quarkus/next/reference/extensions/opentracing.html

@squakez squakez added area/traits area/observability Logging, monitoring and tracing labels Aug 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@gansheer
Copy link
Contributor

gansheer commented Dec 23, 2022

Is the subject of this issue only the task of changing the Tracing trait from OpenTracing to OpenTelemetry (and everything related to this change) or are there some other tasks needed ?

@squakez any detail you know on this issue that could be missed would be greatly appreciated 👍

@squakez
Copy link
Contributor Author

squakez commented Dec 23, 2022

No, I guess it's the only thing to do. Likely we may include more test coverage as a nice to have.

@gansheer
Copy link
Contributor

gansheer commented Jan 4, 2023

The backward compatibility of this change is tricky:

  • quarkus opentracing :
    • compatible with jaeger by connecting directly to the Collector using Thrift over HTTP (example: https://jaeger-collector:14268/api/traces)
    • allows sampler of types : const/probability/ratelimiting/remote
  • quarkus opentelemetry :
    • defaults to gRPC span exporter for OTLP (example : http://localhost:4317)
    • allows samplers of type : on/off/ratio
    • the traces will probably be slightly different

Possible solutions tested :

I only see 2 choices left :

  1. replacing in tracing trait implementation opentracing by opentelemetry => no backward compatibility
  2. adding a new trait (+addon +capability) opentelemetry trait and deprecating the tracing trait

I am in favor of choice 2, adding a new trait, to give users time to do the necessary adaptation (like Jaeger configuration and potential adaptation to the traces generated) before migrating to the new trait.

I will implement the new trait, so if you see something that don't feel right please with this solution don't hesitate to tell me @squakez

@squakez
Copy link
Contributor Author

squakez commented Jan 5, 2023

Thanks for the detailed proposal. If the option 2 does not present any particular problem, definitely, it would be the preferred solution.

gansheer added a commit to gansheer/camel-k-runtime that referenced this issue Jan 5, 2023
gansheer added a commit to gansheer/camel-k-runtime that referenced this issue Jan 10, 2023
* Uses quarkus camel opentelemetry for new telemetry capability

resolves #apache/camel-k#3519
gansheer added a commit to gansheer/camel-k that referenced this issue Jan 10, 2023
* Define telemetry addon
* Jaeger discovery for OTLP API
* Basic configuration for tracing OTLP sampler
* update existing e2e using tracing to telemetry

Resolves: apache#3519
gansheer added a commit to gansheer/camel-k that referenced this issue Jan 10, 2023
* Define telemetry addon
* Jaeger discovery for OTLP API
* Basic configuration for tracing OTLP sampler
* update existing e2e using tracing to telemetry

Resolves: apache#3519
gansheer added a commit to gansheer/camel-k that referenced this issue Jan 10, 2023
* Define telemetry addon
* Jaeger discovery for OTLP API
* Basic configuration for tracing OTLP sampler
* update existing e2e using tracing to telemetry

Resolves: apache#3519
gansheer added a commit to gansheer/camel-k-runtime that referenced this issue Jan 10, 2023
* Uses camel-quarkus opentelemetry extension for new telemetry capability

resolves #apache/camel-k#3519
gansheer added a commit to gansheer/camel-k-runtime that referenced this issue Jan 10, 2023
* Uses camel-quarkus opentelemetry extension for new telemetry capability in catalog

resolves #apache/camel-k#3519
gansheer added a commit to gansheer/camel-k that referenced this issue Jan 10, 2023
* Define telemetry addon
* Jaeger discovery for OTLP API
* Basic configuration for tracing OTLP sampler
* update existing e2e using tracing to telemetry

Resolves: apache#3519
gansheer added a commit to gansheer/camel-k that referenced this issue Jan 11, 2023
* Define telemetry addon
* Jaeger discovery for OTLP API
* Basic configuration for tracing OTLP sampler
* update existing e2e using tracing to telemetry

Resolves: apache#3519
gansheer added a commit to gansheer/camel-k that referenced this issue Jan 11, 2023
* Define telemetry addon
* Jaeger discovery for OTLP API
* Basic configuration for tracing OTLP sampler
* update existing e2e using tracing to telemetry

Resolves: apache#3519
squakez pushed a commit to apache/camel-k-runtime that referenced this issue Jan 11, 2023
* Uses camel-quarkus opentelemetry extension for new telemetry capability in catalog

resolves #apache/camel-k#3519
gansheer added a commit to gansheer/camel-k that referenced this issue Jan 11, 2023
* Define telemetry addon
* Jaeger discovery for OTLP API
* Basic configuration for tracing OTLP sampler
* update existing e2e using tracing to telemetry

Resolves: apache#3519
gansheer added a commit to gansheer/camel-k that referenced this issue Jan 16, 2023
* Define telemetry addon
* Jaeger discovery for OTLP API
* Basic configuration for tracing OTLP sampler
* update existing e2e using tracing to telemetry

Resolves: apache#3519
gansheer added a commit to gansheer/camel-k that referenced this issue Jan 17, 2023
* Define telemetry addon
* Jaeger discovery for OTLP API
* Basic configuration for tracing OTLP sampler
* update existing e2e using tracing to telemetry

Resolves: apache#3519
squakez pushed a commit that referenced this issue Jan 18, 2023
* Define telemetry addon
* Jaeger discovery for OTLP API
* Basic configuration for tracing OTLP sampler
* update existing e2e using tracing to telemetry

Resolves: #3519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants