Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data type converter factory finder discovery in camel-quarkus #3844

Closed
christophd opened this issue Nov 24, 2022 · 0 comments · Fixed by #3912
Closed

Add data type converter factory finder discovery in camel-quarkus #3844

christophd opened this issue Nov 24, 2022 · 0 comments · Fixed by #3912
Labels
area/kamelets

Comments

@christophd
Copy link
Contributor

Kamelets introduces a data type concept as described in #1980

The data type implementations are resolved with factory finder mechanism. We will need to add the factory finder for DataTypeConverters when building the camel-quarkus jar for the integration. This makes sure that META-INF resources for factory finder lookup are included in the jars and runtime is able to resolve the data type implementation at runtime.

Usually this can be done with adding quarkus.camel.service.discovery.include-patterns property at build time.

See apache/camel-kamelets#1162 for details
@christophd christophd mentioned this issue Nov 24, 2022
Merged
christophd added a commit to christophd/camel-k that referenced this issue Dec 15, 2022
@christophd
fix(apache#3844): Add service discovery for Kamelet data type converter
7be83bb 
- Enable service discovery for data type converter resources in order to enable factory finder mechanism when resolving data type implementations
- Add proper quarkus-maven-plugin build time properties for quarkus.camel.* properties
- Fixes the way camel-quarkus build time properties are set (set properties on the quarkus-maven-plugin instead of using generic Maven system properties)
- Explicitly add quarkus.camel.service.discovery.include-patterns for data type converter resources in order to enable lazy loading of Kamelets data type implementations

Relates to apache#1980
@christophd christophd mentioned this issue Dec 15, 2022
Merged
christophd added a commit to christophd/camel-k that referenced this issue Dec 15, 2022
@christophd
fix(apache#3844): Add service discovery for Kamelet data type converter
5aa1055 
- Enable service discovery for data type converter resources in order to enable factory finder mechanism when resolving data type implementations
- Add proper quarkus-maven-plugin build time properties for quarkus.camel.* properties
- Fixes the way camel-quarkus build time properties are set (set properties on the quarkus-maven-plugin instead of using generic Maven system properties)
- Explicitly add quarkus.camel.service.discovery.include-patterns for data type converter resources in order to enable lazy loading of Kamelets data type implementations

Relates to apache#1980
christophd added a commit to christophd/camel-k that referenced this issue Dec 15, 2022
@christophd
fix(apache#3844): Add service discovery for Kamelet data type converter
c257178 
- Enable service discovery for data type converter resources in order to enable factory finder mechanism when resolving data type implementations
- Add proper quarkus-maven-plugin build time properties for quarkus.camel.* properties
- Fixes the way camel-quarkus build time properties are set (set properties on the quarkus-maven-plugin instead of using generic Maven system properties)
- Explicitly add quarkus.camel.service.discovery.include-patterns for data type converter resources in order to enable lazy loading of Kamelets data type implementations

Relates to apache#1980
christophd added a commit to christophd/camel-k that referenced this issue Dec 16, 2022
@christophd
fix(apache#3844): Add service discovery for Kamelet data type converter
edef676 
- Enable service discovery for data type converter resources in order to enable factory finder mechanism when resolving data type implementations
- Add proper quarkus-maven-plugin build time properties for quarkus.camel.* properties
- Fixes the way camel-quarkus build time properties are set (set properties on the quarkus-maven-plugin instead of using generic Maven system properties)
- Explicitly add quarkus.camel.service.discovery.include-patterns for data type converter resources in order to enable lazy loading of Kamelets data type implementations

Relates to apache#1980
christophd added a commit to christophd/camel-k that referenced this issue Dec 16, 2022
@christophd
fix(apache#3844): Add service discovery for Kamelet data type converter
f3ed68f 
- Enable service discovery for data type converter resources in order to enable factory finder mechanism when resolving data type implementations
- Add proper quarkus-maven-plugin build time properties for quarkus.camel.* properties
- Fixes the way camel-quarkus build time properties are set (set properties on the quarkus-maven-plugin instead of using generic Maven system properties)
- Explicitly add quarkus.camel.service.discovery.include-patterns for data type converter resources in order to enable lazy loading of Kamelets data type implementations

Relates to apache#1980
christophd added a commit to christophd/camel-k that referenced this issue Dec 20, 2022
@christophd
fix(apache#3844): Add e2e test for data type converter service discovery
9955b8c 
- Kameletes used in the test make use of DataTypeRegistry and classpath scan is disabled
- Data type registry will then perform a lookup of the data types via service discovery mechanism
christophd added a commit to christophd/camel-k that referenced this issue Dec 20, 2022
@christophd
fix(apache#3844): Add service discovery for Kamelet data type converter
7b33c38 
- Enable service discovery for data type converter resources in order to enable factory finder mechanism when resolving data type implementations
- Add proper quarkus-maven-plugin build time properties for quarkus.camel.* properties
- Fixes the way camel-quarkus build time properties are set (set properties on the quarkus-maven-plugin instead of using generic Maven system properties)
- Explicitly add quarkus.camel.service.discovery.include-patterns for data type converter resources in order to enable lazy loading of Kamelets data type implementations

Relates to apache#1980
christophd added a commit to christophd/camel-k that referenced this issue Dec 20, 2022
@christophd
fix(apache#3844): Add e2e test for data type converter service discovery
3c0a087 
- Kameletes used in the test make use of DataTypeRegistry and classpath scan is disabled
- Data type registry will then perform a lookup of the data types via service discovery mechanism
christophd added a commit to christophd/camel-k that referenced this issue Jan 9, 2023
@christophd
fix(apache#3844): Add service discovery for Kamelet data type converter
474952c 
- Enable service discovery for data type converter resources in order to enable factory finder mechanism when resolving data type implementations
- Add proper quarkus-maven-plugin build time properties for quarkus.camel.* properties
- Fixes the way camel-quarkus build time properties are set (set properties on the quarkus-maven-plugin instead of using generic Maven system properties)
- Explicitly add quarkus.camel.service.discovery.include-patterns for data type converter resources in order to enable lazy loading of Kamelets data type implementations

Relates to apache#1980
christophd added a commit to christophd/camel-k that referenced this issue Jan 9, 2023
@christophd
fix(apache#3844): Add e2e test for data type converter service discovery
bda7d95 
- Kameletes used in the test make use of DataTypeRegistry and classpath scan is disabled
- Data type registry will then perform a lookup of the data types via service discovery mechanism
squakez pushed a commit that referenced this issue Jan 10, 2023
@christophd @squakez
fix(#3844): Add service discovery for Kamelet data type converter
acf7755 
- Enable service discovery for data type converter resources in order to enable factory finder mechanism when resolving data type implementations
- Add proper quarkus-maven-plugin build time properties for quarkus.camel.* properties
- Fixes the way camel-quarkus build time properties are set (set properties on the quarkus-maven-plugin instead of using generic Maven system properties)
- Explicitly add quarkus.camel.service.discovery.include-patterns for data type converter resources in order to enable lazy loading of Kamelets data type implementations

Relates to #1980
squakez pushed a commit that referenced this issue Jan 10, 2023
@christophd @squakez
fix(#3844): Add e2e test for data type converter service discovery
d1af7f9 
- Kameletes used in the test make use of DataTypeRegistry and classpath scan is disabled
- Data type registry will then perform a lookup of the data types via service discovery mechanism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kamelets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#3844): Add service discovery for Kamelet data type converter christophd/camel-k
2 participants
@christophd @squakez