Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Kamelets from a released version #3919

Closed
squakez opened this issue Dec 16, 2022 · 6 comments · Fixed by #3948
Closed

Bundle Kamelets from a released version #3919

squakez opened this issue Dec 16, 2022 · 6 comments · Fixed by #3948
Assignees

Comments

@squakez
Copy link
Contributor

squakez commented Dec 16, 2022

The action of bundling Kamelet, right now is not following a strict release process. We are going and taking the last ones that are present in the Git repository. It may lead to inconsistencies and problems, moreover, at the moment the code in main is not bundling what is in the respective main of Kamelet repo.

I suggest to move to a different strategy, where we get the published maven dependency containing the kamelets instead. In order to work correctly, we also need to use a new versioning for Kamelets on main (ie, atm, 0.11.0-SNAPSHOT instead of main-SNAPSHOT).

@squakez
Copy link
Contributor Author

squakez commented Dec 16, 2022

Ref apache/camel-kamelets#1218

@squakez
Copy link
Contributor Author

squakez commented Dec 16, 2022

@oscerd wdyt?

@oscerd
Copy link
Contributor

oscerd commented Dec 16, 2022

Makes sense. I'll switch to 3.20.0-SNAPSHOT

@squakez
Copy link
Contributor Author

squakez commented Dec 16, 2022

wait.. should be 0.11.0-SNAPSHOT or are we going to aling with Camel release?

@oscerd
Copy link
Contributor

oscerd commented Dec 16, 2022

We should align to camel version. It will be easier to understand the camel version used under the hood

@squakez
Copy link
Contributor Author

squakez commented Dec 20, 2022

Fixed in Kamelets: https://repository.apache.org/content/groups/snapshots/org/apache/camel/kamelets/camel-kamelets/3.20.0-SNAPSHOT/ - we should make the related changes to use them now.

@squakez squakez self-assigned this Dec 21, 2022
squakez added a commit to squakez/camel-k that referenced this issue Dec 21, 2022
squakez added a commit to squakez/camel-k that referenced this issue Dec 21, 2022
squakez added a commit to squakez/camel-k that referenced this issue Dec 21, 2022
squakez added a commit that referenced this issue Dec 21, 2022
squakez added a commit that referenced this issue Dec 21, 2022
squakez added a commit that referenced this issue Dec 21, 2022
squakez added a commit to jboss-fuse/camel-k that referenced this issue Dec 22, 2022
Close apache#3919

Conflict fixed manually

(cherry picked from commit apache/camel-k@29defedac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants