Container trait : setting container.name result in wrong integration condition type Ready

[gansheer]

Environment

Version of camel k client : main (commit 45c2205)
Kubernetes : minikube 1.27.1

Description

I was writing some e2e test on container trait that had a strange behavior on condition status checking.
Using a different Container trait value for container.name than the default integration results in an error in the monitoring of status in the integration object.

To reproduce the problem:

• execute same route with the trait (and without to compare results):

$ kamel run Apps.java --name apps
$ kamel run Apps.java -t container.name=notintegration --name apps2

• Check if the pods are running:

NAMESPACE     NAME                                   READY   STATUS    RESTARTS        AGE
default       pod/apps-5df75b99c-d6fdn               1/1     Running   0               9m39s
default       pod/apps2-657ccf8fd7-bfpwz             1/1     Running   0               9m31s

• Check the integration without the trait:

...
status:
  conditions:
...
  - firstTruthyTime: "2022-12-20T16:17:59Z"
    lastTransitionTime: "2022-12-20T16:17:59Z"
    lastUpdateTime: "2022-12-20T16:17:59Z"
    message: 1/1 ready replicas
    reason: DeploymentReady
    status: "True"
    type: Ready
....

• Check the integration with the trait:

...
status:
  conditions:
...
  - lastTransitionTime: "2022-12-20T16:18:05Z"
    lastUpdateTime: "2022-12-20T16:18:05Z"
    message: 0/1 ready replicas
    reason: DeploymentProgressing
    status: "False"
    type: Ready
....

The code that results in this error is the following :

camel-k/pkg/controller/integration/monitor.go

Lines 410 to 415 in 67aad9b

	func findIntegrationContainer(spec corev1.PodSpec) *corev1.Container {
	for _, c := range spec.Containers {
	if c.Name == "integration" {
	return &c
	}
	}

The container name filter is the hardcoded "integration" value.

The only other way I see that could allow to filter "integration pods" would be to filter by the presence of metadata's label "camel.apache.org/integration" in the pod description.

@squakez @tadayosi do you see another way ?

[tadayosi]

Good catch! Yes, it shouldn't be hardcoded there. Probably the only way to get the designated container name is to get it from the Integration's spec.traits.container.name?