Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to override resources for the quarkus-native task #4956

Closed
lsergio opened this issue Dec 1, 2023 · 1 comment · Fixed by #4964
Closed

Ability to override resources for the quarkus-native task #4956

lsergio opened this issue Dec 1, 2023 · 1 comment · Fixed by #4964
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@lsergio
Copy link
Contributor

lsergio commented Dec 1, 2023

Requirement

As a developer, I'm trying to speed up the native build process by providing more resources to the quarkus-native build task.

Problem

I created an Integration with the following traits:

  traits:
    quarkus:
      buildMode:
        - native
    builder:
      tasksRequestCPU:
      - "quarkus-native:2000m"
      tasksRequestMemory:
      - "quarkus-native:8Gi"

in order to provide more resources to the quarkus-native phase of the build process.

However, the build pod was still created with 1 cpu and 4Gi:

  - command:
    - /bin/bash
    - -c
    - cd maven && ./mvnw package -Dquarkus.package.type=native --global-settings settings.xml
    image: quay.io/quarkus/ubi-quarkus-mandrel-builder-image:23.0-jdk-17
    name: quarkus-native
    resources:
      requests:
        cpu: "1"
        memory: 4Gi
    volumeMounts:
    - mountPath: /builder/kit-clktoa002nnjtch78vg0
      name: camel-k-builder
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: kube-api-access-gdlpv
      readOnly: true
    workingDir: /builder/kit-clktoa002nnjtch78vg0

Proposal

The code might just check if there is configuration for the quarkus-native phase for any of the cpu/memory request or limit configurations and not use the default one if found.

Open questions

No response

@lsergio lsergio added the kind/feature New feature or request label Dec 1, 2023
@squakez
Copy link
Contributor

squakez commented Dec 1, 2023

Yes. This seems to be a bug. We swallow any configuration provided by the user.

@squakez squakez added kind/bug Something isn't working and removed kind/feature New feature or request labels Dec 1, 2023
@squakez squakez added this to the 2.2.0 milestone Dec 1, 2023
@squakez squakez self-assigned this Dec 5, 2023
squakez added a commit to squakez/camel-k that referenced this issue Dec 5, 2023
squakez added a commit that referenced this issue Dec 5, 2023
lsergio pushed a commit to lsergio/camel-k that referenced this issue Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants