Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support component scheme prefix in data type references #5048

Closed
christophd opened this issue Jan 10, 2024 · 1 comment
Closed

Support component scheme prefix in data type references #5048

christophd opened this issue Jan 10, 2024 · 1 comment
Labels
kind/feature New feature or request

Comments

@christophd
Copy link
Contributor

Requirement

Pipes are able to reference data types by their name (e.g. text-plain, avro-binary and so on). When a data type is component specific (e.g. aws2-s3:application-cloudevents) the data type name may use the component scheme as a prefix.

Users run into issues because they are using the component scheme as a prefix when referencing a data type but the Pipe specification must use "scheme" and "format" properties when referencing a data type

Problem

The Pipe specification uses "scheme" and "format" properties when referencing a data type:

dataTypes:
  out:
    scheme: aws2-s3
    format: application-cloudevents

Proposal

We should also allow to use the component scheme as a prefix. Something like

dataTypes:
  out:
    format: aws2-s3:application-cloudevents

Open questions

No response
@christophd christophd added the kind/feature New feature or request label Jan 10, 2024
christophd added a commit to christophd/camel-k that referenced this issue Jan 11, 2024
@christophd
fix(apache#5048): Support component scheme prefix in data type refere…
00def0f 
…nces

- Allows data type references in Pipes to use component scheme as a prefix in the transformer name (e.g. format=aws2-s3:application-cloudevents)
- This is in addition to specifying "scheme" and "format" properties on the data type reference
@christophd christophd mentioned this issue Jan 11, 2024
Merged
christophd added a commit to christophd/camel-k that referenced this issue Jan 11, 2024
@christophd
fix(apache#5048): Support component scheme prefix in data type refere…
3e10c24 
…nces

- Allows data type references in Pipes to use component scheme as a prefix in the transformer name (e.g. format=aws2-s3:application-cloudevents)
- This is in addition to specifying "scheme" and "format" properties on the data type reference
christophd added a commit that referenced this issue Jan 12, 2024
@christophd
fix(#5048): Support component scheme prefix in data type references
5739551 
- Allows data type references in Pipes to use component scheme as a prefix in the transformer name (e.g. format=aws2-s3:application-cloudevents)
- This is in addition to specifying "scheme" and "format" properties on the data type reference
@christophd
Copy link
Contributor Author

Fixed with #5056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@christophd