Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky TestOperatorBasic #5326

Closed
squakez opened this issue Apr 5, 2024 · 3 comments · Fixed by #5338
Closed

Flaky TestOperatorBasic #5326

squakez opened this issue Apr 5, 2024 · 3 comments · Fixed by #5338
Labels
area/test/flakiness

Comments

@squakez
Copy link
Contributor

squakez commented Apr 5, 2024 •
edited 

❌ TestOperatorBasic (25.76s)
...
      operator_test.go:80: 
          Expected
              <string>: 
          to equal
              <string>: kind-registry:5000

Seen several time already. Last time in https://github.com/apache/camel-k/actions/runs/8566597132/job/23476649796
@squakez squakez mentioned this issue Apr 9, 2024
Merged
@tdiesler
Copy link
Contributor

tdiesler commented Apr 9, 2024

CrossRef: https://issues.redhat.com/browse/CMLK-1928

@oscerd
Copy link
Contributor

oscerd commented Apr 9, 2024 •
edited

Please don't use/ref downstream issues in upstream.

@christophd
Copy link
Contributor

This is a racing condition on a slow performing e2e test environment. The test complains about empty registry address assertion but in the following namespace dump I can see the IntegrationPlatform printed and the registry address is set to the expected value already.

I suppose to use an Eventually assertion that waits some time for the registry address to be set properly and only fails after a timeout when the condition is not met.

christophd added a commit to christophd/camel-k that referenced this issue Apr 9, 2024
@christophd
fix(apache#5326): Fix flaky E2E test
6334e15 
- Make sure to wait some time for registry address to be set on IntegrationPlatform status
@christophd christophd mentioned this issue Apr 9, 2024
Merged
@squakez squakez linked a pull request Apr 9, 2024 that will close this issue
fix(#5326): Fix flaky E2E test #5338
Merged
christophd added a commit that referenced this issue Apr 9, 2024
@christophd
fix(#5326): Fix flaky E2E test
f6d38bf 
- Make sure to wait some time for registry address to be set on IntegrationPlatform status
christophd added a commit to christophd/camel-k that referenced this issue Apr 9, 2024
@christophd
fix(apache#5326): Fix flaky E2E test
1c527f1 
- Make sure to wait some time for registry address to be set on IntegrationPlatform status

(cherry picked from commit f6d38bf)
christophd added a commit that referenced this issue Apr 9, 2024
@christophd
fix(#5326): Fix flaky E2E test
652f166 
- Make sure to wait some time for registry address to be set on IntegrationPlatform status

(cherry picked from commit f6d38bf)
squakez pushed a commit to jboss-fuse/camel-k that referenced this issue Apr 9, 2024
@christophd @github-actions
fix(apache#5326): Fix flaky E2E test
555307b 
- Make sure to wait some time for registry address to be set on IntegrationPlatform status

(cherry picked from commit f6d38bf)

(cherry picked from commit apache/camel-k@652f16626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test/flakiness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#5326): Fix flaky E2E test christophd/camel-k
4 participants
@christophd @tdiesler @oscerd @squakez