-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SanitizeName #548
Comments
@jamesnetherton a PR would be very welcome |
jamesnetherton
added a commit
to jamesnetherton/camel-k
that referenced
this issue
Mar 13, 2019
lburgazzoli
pushed a commit
that referenced
this issue
Mar 13, 2019
valdar
pushed a commit
to jboss-fuse/camel-k
that referenced
this issue
May 21, 2019
ipolyzos
pushed a commit
to ipolyzos/camel-k
that referenced
this issue
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I found a couple of small issues with the current implementation of SanitizeName.
You get:
Maybe it'd be better to base the name on the actual file name (just like how it works when passing a filesystem path to the kamel binary). And fallback on host name if its not present.
If we think its worth improving, I can submit a PR.
The text was updated successfully, but these errors were encountered: