Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration logging configuration #580

Closed
astefanutti opened this issue Mar 25, 2019 · 11 comments
Closed

Integration logging configuration #580

astefanutti opened this issue Mar 25, 2019 · 11 comments
Assignees
Labels
area/observability Logging, monitoring and tracing kind/feature New feature or request
Milestone

Comments

@astefanutti
Copy link
Member

We could add a trait that enables to configure logging for integration, e.g. format, level. It should ideally be agnostic from the logging backend and the integration runtime.

@lburgazzoli lburgazzoli added this to the 1.1.0 milestone Jun 5, 2020
@lburgazzoli lburgazzoli added the kind/feature New feature or request label Jun 5, 2020
@davsclaus
Copy link
Contributor

Yeah lets get this into 1.1. For centralized logging (such as FluentD, ES and Kibana) then we may need to output in a format that it can import such as json.

@astefanutti
Copy link
Member Author

Yes, we need to have an option for structured logging.

@lburgazzoli
Copy link
Contributor

I guess this is a good candidate when moving to quarkus as default runtime

@nicolaferraro nicolaferraro modified the milestones: 1.1.0, 1.2.0 Jul 17, 2020
@astefanutti astefanutti added the area/observability Logging, monitoring and tracing label Jul 21, 2020
@astefanutti astefanutti added this to To do in Observability Jul 21, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.2.0, 1.3.0 Oct 7, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.3.0, 1.4.0 Dec 22, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.4.0, 1.5.0 Apr 13, 2021
@viacheslav-fomin-main
Copy link

Hello! Is there a way to use a custom logging appender and stuff? I have my own logback.xml file which I would like to use for camel k integration.

@lburgazzoli
Copy link
Contributor

No, the logging engine is now the one provided by quarkus, see https://quarkus.io/guides/logging

@viacheslav-fomin-main
Copy link

image

The url says it supports SLF4J. How can I configure it? I want to add the xml configuration file.

@lburgazzoli
Copy link
Contributor

it supports SLF4J APIs but the configuration happens through properties as described int he logging guide (at least that is my understanding)

@viacheslav-fomin-main
Copy link

@lburgazzoli thanks for the clarification! I want to try https://github.com/quarkiverse/quarkus-logging-json and its custom log handler. I am not sure how to use CDI to inject JsonProvider.. Does not seem to work for me.. Can you please advise?

@lburgazzoli
Copy link
Contributor

In such case you need to bring the handler as part of a custom artifact as camel-k does not expose CDI facilities (at least for now). Be aware that you need to index the artifact using Jandex or add a beans.xml to get quarkus be able to find your handler.

@orpiske
Copy link
Contributor

orpiske commented Apr 30, 2021

I'm looking at this.

@orpiske
Copy link
Contributor

orpiske commented May 3, 2021

These PRs mentioned throughout this discussion have added the support for the logging trait. As discussed w/ @astefanutti, now that the documentation is in place, we can close this.

@orpiske orpiske closed this as completed May 3, 2021
@astefanutti astefanutti moved this from To do to In progress in Observability May 11, 2021
@astefanutti astefanutti moved this from In progress to Done in Observability May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/observability Logging, monitoring and tracing kind/feature New feature or request
Projects
No open projects
Observability
  
Done
Development

No branches or pull requests

6 participants