Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adjusting the log level for integrations #2258

Merged
merged 1 commit into from
May 3, 2021

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented May 3, 2021

This solves issue #2000

Release Note

Support adjusting the log level for integrations

@orpiske
Copy link
Contributor Author

orpiske commented May 3, 2021

extra-logging

@heiko-braun
Copy link

@orpiske Would it be possible to backport this onto 1.4.x?

@orpiske
Copy link
Contributor Author

orpiske commented May 3, 2021

@orpiske Would it be possible to backport this onto 1.4.x?

I think so. We would need to backport other 2 patches/commits with the trait support, but it should be small.

That said: there is a work-around for 1.4 that would not require backporting. What do you think @astefanutti / @nicolaferraro ?

@astefanutti
Copy link
Member

@orpiske I'm OK back porting the whole logging trait into 1.4.x branch.

Also, to wrap that great work with an equally great documentation, I would suggest to remove the existing page:

https://camel.apache.org/camel-k/latest/configuration/logging.html

And create a new one under "Observability/Logging" covering the new feature introduced by your work.

@orpiske
Copy link
Contributor Author

orpiske commented May 3, 2021

@orpiske I'm OK back porting the whole logging trait into 1.4.x branch.

Deal. I will take care of that and will open a PR for 1.4.x.

Also, to wrap that great work with an equally great documentation, I would suggest to remove the existing page:

https://camel.apache.org/camel-k/latest/configuration/logging.html

And create a new one under "Observability/Logging" covering the new feature introduced by your work.

Thanks! Deal. I will do that on a separate PR, as I have to check a bit more carefully about removing the doc part.

@astefanutti
Copy link
Member

@orpiske awesome! Once the documentation work is done, I think we can close #580.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants