Misleading "service.enabled=false" when used in combination with the prometheus trait

[lburgazzoli]

Assuming I run an integration with

-t service.enabled=false -t prometheus.enabled=true

My expectation is that no services are created, but instead the prometheus trait does create it so I'm wondering if we should re-think the service trait and reason more in term of container port so:

• every trait could add ports definitions
• the service trait will assemble the service as final step

type containerTrait struct {
	BaseTrait `property:",squash"`

	RequestCPU      string `property:"request-cpu"`
	RequestMemory   string `property:"request-memory"`
	LimitCPU        string `property:"limit-cpu"`
	LimitMemory     string `property:"limit-memory"`

	Port            int32  `property:"port"`
	PortName        string `property:"port-name"`
	ServicePort     int32  `property:"service-port"`
	ServicePortName int32  `property:"service-port-name"`
}

type prometheusTrait struct {
	BaseTrait `property:",squash"`

	Port                 int    `property:"port"`
	PortName             string `property:"port-name"`
	ServicePort          int32  `property:"service-port"`
	ServicePortName      int32  `property:"service-port-name"`

	ServiceMonitor       bool   `property:"service-monitor"`
	ServiceMonitorLabels string `property:"service-monitor-labels"`
}