Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable container name #826

Closed
lburgazzoli opened this issue Jul 17, 2019 · 0 comments · Fixed by #835
Closed

Stable container name #826

lburgazzoli opened this issue Jul 17, 2019 · 0 comments · Fixed by #835
Assignees
@lburgazzoli
Labels
kind/feature New feature or request
Milestone
1.0.0-M1

Comments

@lburgazzoli
Copy link
Contributor

When camel-k creates a deployment, it sets the name of the container after the name of the integration instead, when a knative service is created, the container name is not set.

For better user experience it could be nice to:

  • by default, set the name of the container to integration-container for deployments and knative services
  • have an option to customize the container name -t container.name=something
@lburgazzoli lburgazzoli added the kind/feature New feature or request label Jul 17, 2019
@lburgazzoli lburgazzoli self-assigned this Jul 18, 2019
@lburgazzoli lburgazzoli added this to the 1.0.0-M1 milestone Jul 18, 2019
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 18, 2019
@lburgazzoli
Stable container name apache#826
c558322
@lburgazzoli lburgazzoli mentioned this issue Jul 18, 2019
Merged
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 18, 2019
@lburgazzoli
Stable container name apache#826 (pr review)
96f3aaf
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Jul 18, 2019
@lburgazzoli
Stable container name apache#826 (pr review)
fb73741
lburgazzoli added a commit that referenced this issue Jul 18, 2019
@lburgazzoli
Stable container name #826
98a8b9b
lburgazzoli added a commit that referenced this issue Jul 18, 2019
@lburgazzoli
Stable container name #826 (pr review)
29df016
ipolyzos pushed a commit to ipolyzos/camel-k that referenced this issue Jul 31, 2019
@lburgazzoli @ipolyzos
Stable container name apache#826
95ac2c2
ipolyzos pushed a commit to ipolyzos/camel-k that referenced this issue Jul 31, 2019
@lburgazzoli @ipolyzos
Stable container name apache#826 (pr review)
b5e278a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lburgazzoli lburgazzoli

Labels
kind/feature New feature or request
Projects
None yet
Milestone
1.0.0-M1
Development

Successfully merging a pull request may close this issue.

Stable container name lburgazzoli/apache-camel-k
1 participant
@lburgazzoli