Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camel K should use duck types to recognize Knative sinks #888

Closed
nicolaferraro opened this issue Jul 30, 2019 · 2 comments
Closed

Camel K should use duck types to recognize Knative sinks #888

nicolaferraro opened this issue Jul 30, 2019 · 2 comments
Assignees
@nicolaferraro
Labels
area/knative Related to Knative kind/bug Something isn't working
Milestone
1.0.0-M2

Comments

@nicolaferraro
Copy link
Member

We're currently analyzing channels and services by looking at their types, but e.g. some channels are moving to their own CRD in Knative (e.g. KafkaChannel), so they won't be recognized.

knative/eventing#1216
@nicolaferraro nicolaferraro added area/knative Related to Knative kind/bug Something isn't working labels Jul 30, 2019
@nicolaferraro nicolaferraro added this to the 1.0.0 milestone Jul 30, 2019
@nicolaferraro nicolaferraro modified the milestones: 1.0.0, 1.0.0-M2 Sep 24, 2019
@nicolaferraro
Copy link
Member Author

This is an issue with knative 0.8+ releases where e.g. channels have been moved from eventing.knative.dev to messaging.knative.dev

@nicolaferraro nicolaferraro self-assigned this Sep 24, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Sep 26, 2019
@nicolaferraro
Fix apache#952, apache#888: upgrade to Knative 0.9.0
5ba8163
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Sep 26, 2019
@nicolaferraro
Fix apache#952, apache#888: upgrade to Knative 0.9.0
c50b0a0
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Sep 26, 2019
@nicolaferraro
Fix apache#952, apache#888: fix findings
2526409
nicolaferraro added a commit that referenced this issue Oct 1, 2019
@nicolaferraro
Fix #952, #888: upgrade to Knative 0.9.0
c77912d
nicolaferraro added a commit that referenced this issue Oct 1, 2019
@nicolaferraro
Fix #952, #888: fix findings
b5e6e37
@nicolaferraro
Copy link
Member Author

Fixed by #961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolaferraro nicolaferraro

Labels
area/knative Related to Knative kind/bug Something isn't working
Projects
None yet
Milestone
1.0.0-M2
Development

No branches or pull requests
1 participant
@nicolaferraro