Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving api to v1 #921

Closed
lburgazzoli opened this issue Sep 3, 2019 · 4 comments · Fixed by #1160
Closed

Moving api to v1 #921

lburgazzoli opened this issue Sep 3, 2019 · 4 comments · Fixed by #1160
Assignees
Milestone

Comments

@lburgazzoli
Copy link
Contributor

As we are approaching v1.0.0 we should think about moving the camel-k API out of alpha/beta and move to v1

//cc @nicolaferraro @astefanutti

@lburgazzoli lburgazzoli added this to the 1.0.0 milestone Sep 3, 2019
@astefanutti
Copy link
Member

Totally makes sense.

@lburgazzoli lburgazzoli modified the milestones: 1.0.0, 1.0.0-CR1 Nov 28, 2019
@nicolaferraro nicolaferraro self-assigned this Dec 17, 2019
@nicolaferraro
Copy link
Member

We can set versions like this:

  versions:
    - name: v1alpha1
      served: true
      storage: false
    - name: v1
      served: true
      storage: true

It means that we store resources in version v1 but also clients using v1alpha1 will still continue to work (e.g. Knative Camel Sources and others).

This change assumes that there are no changes between v1alpha1 and v1. The alternative is to adding mutating webhooks, which complicates too much the deployment.
Since we're moving from alpha to stable, I'd do minor changes without caring about conversion (mentioning possible minor changes in release notes).

I'd migrate all APIs to v1 because Integration and IntegrationPlatform are pretty stable and all the others are internal APIs and people should not care a lot about their stability.

I'd do all changes after other big PRs are merged.. doing some tests now.

@nicolaferraro
Copy link
Member

cc: @lburgazzoli , @astefanutti

@astefanutti
Copy link
Member

Sounds like a perfect plan to me 👍

nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants