Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Knative broker/trigger model and explicit source/sink #1012

Merged

Conversation

nicolaferraro
Copy link
Member

@nicolaferraro nicolaferraro commented Oct 14, 2019

This aligns to the changes done in the runtime to support the broker/trigger model.

Marking as WIP because I want to add some integration tests with the broker.

Release Note

Added support for Knative Broker/Trigger model and explicit source/sink selection

@nicolaferraro nicolaferraro added the status/wip Work in progress label Oct 14, 2019
@nicolaferraro nicolaferraro changed the title Knative explicit source target Support Knative broker/trigger model and explicit source/sink Oct 15, 2019
@nicolaferraro
Copy link
Member Author

@lburgazzoli it seems the error is related to the upgrade to runtime snapshot.
Any hint?

Camel K installed in namespace test-61fc0082-f821-41c4-b840-35789a2d0390
--- FAIL: TestKitHealthFullBuild (309.54s)
    build_test.go:71: 
        Timed out after 300.000s.
        Expected
            <v1alpha1.BuildPhase>: Error
        to equal
            <v1alpha1.BuildPhase>: Succeeded

@lburgazzoli
Copy link
Contributor

lburgazzoli commented Oct 15, 2019

The test name seems to be misleading because actually it test the installation of the knative kit, see TestKitHealthFullBuild

I've tested it locally and the kit is properly created so wondering if you have defined the snapshot repo in the test namespace.

When running from the integration tests:

camel-k-main-builder builder [ERROR] [ERROR] Some problems were encountered while processing the POMs:
camel-k-main-builder builder [ERROR] Non-resolvable import POM: Could not find artifact org.apache.camel.k:camel-k-runtime-bom:pom:1.0.5-SNAPSHOT @ line 16, column 19
camel-k-main-builder builder [ERROR] 'dependencies.dependency.version' for org.apache.camel.k:camel-k-runtime-main:jar is missing. @ line 26, column 17
camel-k-main-builder builder  @ 
camel-k-main-builder builder [ERROR] The build could not read 1 project -> [Help 1]
camel-k-main-builder builder [ERROR]   
camel-k-main-builder builder [ERROR]   The project org.apache.camel.k.integration:camel-k-integration:1.0.0-M3-SNAPSHOT (/workspace/builder-611527789/maven/pom.xml) has 2 errors
camel-k-main-builder builder [ERROR]     Non-resolvable import POM: Could not find artifact org.apache.camel.k:camel-k-runtime-bom:pom:1.0.5-SNAPSHOT @ line 16, column 19 -> [Help 2]
camel-k-main-builder builder [ERROR]     'dependencies.dependency.version' for org.apache.camel.k:camel-k-runtime-main:jar is missing. @ line 26, column 17
camel-k-main-builder builder [ERROR] 
camel-k-main-builder builder [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
camel-k-main-builder builder [ERROR] Re-run Maven using the -X switch to enable full debug logging.
camel-k-main-builder builder [ERROR] 
camel-k-main-builder builder [ERROR] For more information about the errors and possible solutions, please read the following articles:
camel-k-main-builder builder [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
camel-k-main-builder builder [ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException

which is likely to be the snapshot repo not configured.

I think that snapshot repos should always be enabled for e2e

@nicolaferraro
Copy link
Member Author

There was a lib not explicitly listed in the dev build pom (should work even without snapshot repo).

@nicolaferraro nicolaferraro removed the status/wip Work in progress label Oct 15, 2019
@@ -0,0 +1,138 @@
package knative
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add license header here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants