fix #1023: add possibility to reference staging artifacts #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Oct 28, 2019
WillemJiang
reviewed
Oct 29, 2019
| @@ -33,6 +33,8 @@ LINT_DEADLINE := 5m | |||
| # Used to push pre-relase artifacts | |||
| STAGING_IMAGE_NAME := docker.io/camelk/camel-k | |||
|
|
|||
| STAGING_RUNTIME_REPO := https://repository.apache.org/content/repositories/orgapachecamel-1160 | |||
There was a problem hiding this comment.
It's could be better if we can pass the staging repo url as an environment variable.
There was a problem hiding this comment.
This allows to switch the main repo to a staging version before we officially release it, making travis building in the meantime. If you want to customize it locally you can still run e.g. make STAGING_RUNTIME_REPO=https://another-repo test-integration
davsclaus
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1023
And switch to runtime 1.0.6
Release Note