Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the version of the operator image #1077

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Nov 22, 2019

It should be a minor issue.

@jamesnetherton
Copy link
Contributor

You've modified a generated file.

Make the same change here. Then do:

make build-resources

Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting it.. can you also fix the corresponding yaml file in the /deploy dir, otherwise it gets recreated when making make build-resources.

@nicolaferraro
Copy link
Member

You've modified a generated file.

Make the same change here. Then do:

make build-resources

ahaha

@zhfeng
Copy link
Contributor Author

zhfeng commented Nov 22, 2019

Thanks all and I will fix the yaml file.

@nicolaferraro
Copy link
Member

Tbh, @zhfeng I need to thank you.. I was struggling since 30 mins because my changes to the operator weren't published ...

@zhfeng
Copy link
Contributor Author

zhfeng commented Nov 22, 2019

@nicolaferraro I met the same issue here :)

@astefanutti astefanutti merged commit 7c514e3 into apache:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants