Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): Add affinity trait examples back #1098

Merged
merged 1 commit into from Nov 26, 2019
Merged

fix(doc): Add affinity trait examples back #1098

merged 1 commit into from Nov 26, 2019

Conversation

astefanutti
Copy link
Member

Release Note

NONE

nicolaferraro
nicolaferraro approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've left them behind.
I've added the possibility to edit the adoc file directly in case the description becomes too much verbose. Examples may be one case where we opt for the adoc, maybe adding a specific paragraph. We should decide for best..

@astefanutti
Copy link
Member Author

@nicolaferraro Ah you're right. Probably better adding the examples in a dedicated section of the doc file. Let me re-push it.

@astefanutti
Copy link
Member Author

Moved to the docs. Thanks!

@nicolaferraro
Copy link
Member

Much better ;)

@nicolaferraro nicolaferraro merged commit c763829 into apache:master Nov 26, 2019
@astefanutti astefanutti deleted the pr-83 branch November 26, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@astefanutti @nicolaferraro @oscerd