Speed up s2i a little bit #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Sep 21, 2018
lburgazzoli
approved these changes
Sep 21, 2018
|
What do you think about to add minimal set of the maven artifacts (camel-core and camel-groovy) inside the Docker image to speedup build? Or it's a crazy idea? |
|
It is should be already that case, there are two contexts aka images that are provisioned when kamel is installed, see: to see what it is included: |
|
Yes, exactly. This PR is expected to build other context images on top of existing contexts. E.g. the |
|
Now it's ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now maven and s2i can do interleaved work in the pipeline. Plus a filter to push only certain artifacts in the s2i build.