Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gc): Do not log 403 errors on deletecollection requests during GC #1150

Merged
merged 1 commit into from
Dec 17, 2019
Merged

fix(gc): Do not log 403 errors on deletecollection requests during GC #1150

merged 1 commit into from
Dec 17, 2019

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Dec 17, 2019

Fixes #1140.

Release Note

NONE

@nicolaferraro
Copy link
Member

Did you have also a look at #1027? Seems another category of error to skip.

I've not found a k8s API to deal with unknown API, so I've added a util method

return err != nil && strings.HasPrefix(err.Error(), "no matches for kind")

@astefanutti
Copy link
Member Author

It seems to me #1027 is a different kind of error:

  • The GC relies on the discovery API that has returned the CamelSource type, so I find it strange the delete operation fails with the no matches for kind error,
  • I'm not sure the integration GC should actually enlist the CamelSource type for GC. I think it happens by accident as it happens the label selector matches the CamelSource owner, while it should probably not.

@nicolaferraro
Copy link
Member

Yeah, I can see it's a strange error.
I'm moving that issue out of the milestone as it does not happen consistently.

@astefanutti astefanutti merged commit a3c3b2a into apache:master Dec 17, 2019
@astefanutti astefanutti deleted the pr-87 branch December 17, 2019 14:43
@astefanutti astefanutti restored the pr-87 branch December 17, 2019 17:56
@astefanutti astefanutti deleted the pr-87 branch November 22, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gc] cannot delete collection resource "daemonsets"
2 participants