fix(CLI): Cannot set Kaniko cache option #1166
Conversation
| @@ -280,7 +280,8 @@ func (o *installCmdOptions) install(_ *cobra.Command, _ []string) error { | |||
| } | |||
| } | |||
|
|
|||
| if !o.KanikoBuildCache { | |||
| kanikoBuildCacheFlag := cobraCmd.Flags().Lookup("kaniko-build-cache") | |||
| if kanikoBuildCacheFlag.Changed { | |||
There was a problem hiding this comment.
why is this needed ? the KanikoBuildCache should be set already by the pre run task and should be true by default
There was a problem hiding this comment.
With #1121, the default is now false. With falsy default, we have the possibility to set the option even if it's not explicitly provided. Still, it seems more user-friendly not to fill the Spec struct with default values. Boolean is a special case as zero value is also a valid value.
There was a problem hiding this comment.
So we can just flip the if previously in place I guess
There was a problem hiding this comment.
Yes, unless we find it more user-friendly not to fill the Spec struct with default values altogether.
There was a problem hiding this comment.
but if you flip the switch, the default won't be set, isn't it ?
There was a problem hiding this comment.
Yes, but if the user explicitly set the option to false, it won't be set either, which doesn't really make sense.
There was a problem hiding this comment.
ah ok, understood.
so let merge it, problem is that this wont' work with the env + file thing.
I'll think about a solution later on
Release Note