Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kamel run --wait should return non-zero exit code in case of failure #1178

Merged
merged 1 commit into from
Jan 7, 2020
Merged

kamel run --wait should return non-zero exit code in case of failure #1178

merged 1 commit into from
Jan 7, 2020

Conversation

jamesnetherton
Copy link
Contributor

fixes #1170

Note: I enabled SilenceUsage on the Cobra config because it looks a bit weird when a command fails to print the kamel usage blurb. You can still get usage via the help switch or if invalid args / commands were given.

Release Note

NONE

nicolaferraro
nicolaferraro approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicolaferraro nicolaferraro merged commit 2eb3f4d into apache:master Jan 7, 2020
@jamesnetherton jamesnetherton deleted the 1170-exit-codes branch January 7, 2020 10:25
@jamesnetherton jamesnetherton mentioned this pull request Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kamel run --wait should return non-zero exit code in case of failure
3 participants
@jamesnetherton @nicolaferraro @oscerd