fix #1222: use image sha in s2i build to avoid knative registry resol… #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefanutti
approved these changes
Feb 12, 2020
oscerd
approved these changes
Feb 12, 2020
|
I'm trying to replicate this with Buildah in the context of #1259. I've just realised Buildah is returning the image Id digest, which is different from the repository digest :( Once I've managed to retrieve the correct digest, I'll factorize the code for Buildah and s2i. |
|
That works also for Buildah: 384541d#diff-8bfaca691ee0b99d585e230595d49e6aR230. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ution
cc: @astefanutti
Release Note