Fix #1379: make download link available also when installing from operator hub #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaferraro
commented
Mar 30, 2020
Comment on lines
+404
to
+411
| - apiGroups: | ||
| - rbac.authorization.k8s.io | ||
| resourceNames: | ||
| - system:image-builder | ||
| resources: | ||
| - clusterroles | ||
| verbs: | ||
| - bind |
There was a problem hiding this comment.
@astefanutti this is auto-generated from the OLM role file. Does this need to be a role or a clusterrole? I'm not sure, since you deal with a cluster resource but you want to bind it locally...
I've left it as you did
There was a problem hiding this comment.
IIRC, I think a role is enough as it is granted for the operator SA in its namespace.
astefanutti
approved these changes
Mar 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rator hub
Fix #1379
Release Note