Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially Fixes Camel 14995: generates master and 3/threescale traits docs. #1441

Merged
merged 2 commits into from
May 5, 2020

Conversation

djencks
Copy link
Contributor

@djencks djencks commented May 4, 2020

This adjusts the source locations in script/gen_doc.sh to actually find the master and threescale source and thus generate the docs. The solution seems to be to list each source directory explicitly. I haven't found any documentation on --input-dirs or been able to discover where it is used or what format it is supposed to be in.

This is seriously incomplete for a robust solution:

  • possible other traits in addons need to be added to gen_doc.sh by hand. This IMO is not likely to happen.
  • There is no check that every checked in .adoc that was once generated is still generated. In fact I have found no evidence that gen_docs.sh is run as part of ci.

@oscerd oscerd merged commit 88e979b into apache:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants