Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitized integration name on Windows contains whole path #1484

Merged
merged 1 commit into from Jun 4, 2020
Merged

sanitized integration name on Windows contains whole path #1484

merged 1 commit into from Jun 4, 2020

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Jun 3, 2020

Release Note

NONE

Fixes #1462

@oscerd
Copy link
Contributor Author

oscerd commented Jun 3, 2020

Locally all the tests passes. I guess those are glitches.

@astefanutti
Copy link
Member

The tests should be fixed with #1485. Let me re-spin them.

@astefanutti
Copy link
Member

Let's merge this. Tests are fixed with #1485.

@astefanutti astefanutti merged commit 83ccc4b into master Jun 4, 2020
@astefanutti astefanutti deleted the sanitize-name-fix branch June 4, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti approved these changes

@nicolaferraro nicolaferraro nicolaferraro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sanitized integration name on Windows contains whole path
3 participants
@oscerd @astefanutti @nicolaferraro