Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jvm): Integration do not shutdown gracefully when jvm.print-command is set #1558

Merged
merged 1 commit into from Jun 25, 2020
Merged

fix(jvm): Integration do not shutdown gracefully when jvm.print-command is set #1558

merged 1 commit into from Jun 25, 2020

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Jun 24, 2020 •
edited

Fixes #1557.

The wrapping shell does not forward signals like SIGTERM to the JVM process it is waiting on, and exec should be used to have the shell replaced with the JVM process being opened.

Release Note

fix(jvm): Integration do not shutdown gracefully when jvm.print-command is set

@astefanutti astefanutti added backport release-1.0.x kind/bug Something isn't working labels Jun 24, 2020
@astefanutti astefanutti merged commit 0531788 into apache:master Jun 25, 2020
@nicolaferraro nicolaferraro mentioned this pull request Jun 25, 2020
Closed
@astefanutti astefanutti deleted the pr-117 branch June 25, 2020 14:59
@aldettinger aldettinger mentioned this pull request Jun 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration do not shutdown gracefully when jvm.print-command is set
3 participants
@astefanutti @nicolaferraro @oscerd