feat(crd): Generate CRDs from APIs #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface members are not supported by controller-tools that's used for generating CRDs. See kubernetes-sigs/controller-tools#126
oscerd
approved these changes
Jun 29, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the generation of the CRDs from the APIs, using the
controller-genCLI, which is part of the KubeBuilder project.The Operator SDK wraps it to provide a CLI to generate CRDs. However, it does not work for Camel K APIs, as these are packaged in their own module, which is not the project root module.
This PR supersedes #1514: it prepares the upgrade to
apiextensions.k8s.io/v1(#1487), as it introduces structural schema for CRDs, which is mandatory forv1, yet it does not bring the upgrade as #1550 blocks it.Mind this PR also drops serving
camel.apache.org/v1alpha1.Release Note