Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1536: take modeline changes into account in dev mode #1634

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Fix #1536: take modeline changes into account in dev mode #1634

merged 2 commits into from
Jul 27, 2020

Conversation

johnpoth
Copy link
Member

Release Note

NONE

oscerd
oscerd approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @lburgazzoli

nicolaferraro
nicolaferraro approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple solution :)

@oscerd oscerd merged commit 849484e into apache:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnpoth @nicolaferraro @oscerd