Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Create integration test for exposing metrics to prometheus #1660

Merged
merged 2 commits into from
Aug 19, 2020

Conversation

llowinge
Copy link
Contributor

@llowinge llowinge commented Aug 12, 2020

This is basic test scenario covering https://issues.redhat.com/browse/ENTESB-13667.

Release Note

NONE

@llowinge
Copy link
Contributor Author

@astefanutti please review

@llowinge llowinge force-pushed the master branch 4 times, most recently from 0c9e674 to ba182c2 Compare August 17, 2020 08:17
@llowinge
Copy link
Contributor Author

@astefanutti Shouldn't i use oc client instead of kubectl ? (i'm not sure if the Prometheus monitoring is also in plain Kubernetes). If so, should i also change the way how the tests are triggered by the automation ? Because they should run only on openshift then (now they run as part of kubernetes github action).

<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-microprofile-metrics</artifactId>
<version>1.0.0-CR2</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astefanutti Any idea how we could keep this up to date ?

@astefanutti
Copy link
Member

@astefanutti Shouldn't i use oc client instead of kubectl ? (i'm not sure if the Prometheus monitoring is also in plain Kubernetes). If so, should i also change the way how the tests are triggered by the automation ? Because they should run only on openshift then (now they run as part of kubernetes github action).

The Prometheus trait also works with vanilla Kubernetes, so it should ideally be tested also. The assertions will probably have to be different, as for vanilla Kubernetes Thanos is not a pre-requisite.

It is fine to use kubectl even on OpenShift. Both oc and kubectl can be used interchangeably (except for oc specific commands), but one may chose to use oc for OpenShift environment for consistency purpose.

@@ -0,0 +1,4 @@
jdk:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the tests would not depend on Jitpack. Unfortunately, the service bean has to be compiled beforehand and provided as an external bean archive JAR, so it has to be served from a Maven repository.

@llowinge
Copy link
Contributor Author

@astefanutti Do you know why the travis failed ?

@astefanutti
Copy link
Member

@llowinge I've restarted the tests. It failed because of a connection timeout.

Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants