fix: Uninstall cluster role bindings #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cluster role bindings to uninstall procedure. Also add default app labels to cluster wide resources during installation so the resources can be uninstalled properly.
christophd
force-pushed
the
fix/uninstall-cluster-resources
branch
from
c22300f
to
06efe09
Compare
oscerd
approved these changes
Oct 2, 2020
astefanutti
approved these changes
Oct 2, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default app labels to cluster wide resources during installation so the resources can be uninstalled properly. Also uninstall cluster role bindings.
Release Note