Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Detect camel quarkus version dynamically in monitoring test #1795

Merged
merged 1 commit into from
Oct 30, 2020
Merged

[test] Detect camel quarkus version dynamically in monitoring test #1795

merged 1 commit into from
Oct 30, 2020

Conversation

llowinge
Copy link
Contributor

No description provided.

astefanutti
astefanutti approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Should we remove the comment:

camel-k/e2e/yaks/openshift/monitoring/app/pom.xml

Line 29 in cad0ed3

<!-- Will be replaced by sed to test specific version. -->

@llowinge
Copy link
Contributor Author

@astefanutti Yes, i will remove it. Btw. should i even remove the whole line
<version.camel.quarkus>1.0.0-CR2</version.camel.quarkus> ? It would be more safe so we will test with the correct version. But i will leave decision up to you.

@astefanutti
Copy link
Member

@llowinge right, let's remove the version.camel.quarkus default.

@astefanutti astefanutti merged commit 727a8d7 into apache:master Oct 30, 2020
@astefanutti
Copy link
Member

Thanks!

@nicolaferraro nicolaferraro mentioned this pull request Dec 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@llowinge @astefanutti @oscerd