chore(e2e): add test for Prometheus trait #1547

[tadayosi]

It passes fine on OCP but there is a known issue with Minikube #1848.

Release Note

NONE

[astefanutti]

Hi @tadayosi, the tests fail because the ServiceMonitor CRD is not installed:

error executing post actions: error during replace resource: could not create or replace resource java: no matches for kind \"ServiceMonitor\" in version \"monitoring.coreos.com/v1\"

It fails also on OpenShift 3.11 for the same reason. The -t prometheus.service-monitor=false option should probably be passed to the kamel run command.

[astefanutti]

Thanks!

[tadayosi]

@astefanutti Thanks for your feedback. I'm not certain what's really happening with the openshift integration test though, as the output log shows that it didn't run on OpenShift according to:

--- SKIP: TestPlatformlessRun (0.00s)
Error:     platformless_run_test.go:41: This test is for OpenShift only and cannot work when a custom platform configuration is needed

So I have an impression that it's failing just due to #1848. It makes sense to add -t prometheus.service-monitor=false and suppress checking of ServiceMonitor creation for the time being but we may still see the same errors.

[astefanutti]

@astefanutti Thanks for your feedback. I'm not certain what's really happening with the openshift integration test though, as the output log shows that it didn't run on OpenShift according to:

--- SKIP: TestPlatformlessRun (0.00s)
Error: platformless_run_test.go:41: This test is for OpenShift only and cannot work when a custom platform configuration is needed

This is the TestPlatformlessRun test.

So I have an impression that it's failing just due to #1848. It makes sense to add -t prometheus.service-monitor=false and suppress checking of ServiceMonitor creation for the time being but we may still see the same errors.

It fails also on OpenShift workflow, because that is OpenShift 3.11 and the Prometheus operator isn't installed OOTB, as opposed to OCP 4.

[tadayosi]

@astefanutti Ah you are right. I was confused on TestPlatformlessRun, where I thought it's skipped because ocp != true but it rather seems because needsExternalRepo != nil.

Let me try adding -t prometheus.service-monitor=false to see if we could remove the CI errors.

[tadayosi]

Hmm, so it appears that what blocks the test now is #1848. It seems Prometheus trait doesn't deploy not only on k8s but also OCP 3.11.

[astefanutti]

Minikube doesn't have the Prometheus operator installed OOTB either, so it fails with the same error. The option to disable the creation of the ServiceMonitor should also be added on vanilla Kubernetes.

[tadayosi]

I'm trying to fix #1848 first.

[astefanutti]

This can be rebased as #1848 has been merged.