Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trait): toleration trait #2040

Merged
merged 8 commits into from
Feb 19, 2021
Merged

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Feb 17, 2021

With this PR we introduce a new trait to include Tolerations configuration for an integration

Release Note

feat(trait): toleration trait

* Added a new trait to enable tolerations on scheduling pods
* Related unit test included
pkg/trait/toleration.go Outdated Show resolved Hide resolved
pkg/trait/toleration.go Show resolved Hide resolved
* Refactored the logic to accept more than a single toleration
* Support for taint regular expression as required by kubernetes
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍🏼!

pkg/trait/toleration.go Outdated Show resolved Hide resolved
pkg/trait/toleration.go Show resolved Hide resolved
docs/modules/traits/pages/toleration.adoc Outdated Show resolved Hide resolved
@astefanutti astefanutti merged commit 52e0d22 into apache:master Feb 19, 2021
@astefanutti
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants