Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kamelets): embed kamelet repository and remove lookup from gith… #2086

Merged
merged 4 commits into from
Mar 17, 2021

Conversation

nicolaferraro
Copy link
Member

…ub strategy

This automatically syncs kamelets from the catalog into the operator, without relying on github APIs.

I've added a guard to prevent us releasing a non-tagged revision of the catalog during release.

Release Note

The Kamelet catalog is automatically installed on Kubernetes to let other platforms use it

@nicolaferraro nicolaferraro added the kind/feature New feature or request label Mar 2, 2021
@lburgazzoli
Copy link
Contributor

lburgazzoli commented Mar 3, 2021

I think it is ok as long as the number of kamelet is low but as long term strategy I'd advocate for copy the kamelet to the container image and use a local kamelet repository (we then need to add an option to the operator and the kamel cli to point to that location so it would work also for local run)

@heiko-braun
Copy link

How about shipping the kameletes in a separate image, rather than embedded in the operator? It would help if the Kameletes could be updated without touching the operator image. Food for thought.

@nicolaferraro
Copy link
Member Author

I think it is ok as long as the number of kamelet is low but as long term strategy I'd advocate for copy the kamelet to the container image and use a local kamelet repository (we then need to add an option to the operator and the kamel cli to point to that location so it would work also for local run)

I'm in favor of this solution for the short term, bundling the kamelets in the binary is useful to implement kamel local bind, but we agreed on making the CLI lighter and "version independent" in the future, so embedding kamelets goes against this. The local bind can be still implemented and require setting the repo location in advance.

For the long run, an external image may be the solution. It can be shipped directly as release artifact of https://github.com/apache/camel-kamelets. But decoupling kamelet catalog version from operator version require more thinking, especially from an operational point of view.

@nicolaferraro nicolaferraro merged commit 811d51c into apache:master Mar 17, 2021
@nicolaferraro nicolaferraro mentioned this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants