Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): toleration install flag #2114

Merged
merged 3 commits into from
Mar 26, 2021
Merged

feat(operator): toleration install flag #2114

merged 3 commits into from
Mar 26, 2021

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Mar 11, 2021

  • Refactored toleration trait to create Tolerations in a util method
  • Refactored OperatorOrCollect method to ease readability
  • Added toleration configuration in OLM and non OLM installations

With this PR we introduce the possibility to setup Tolerations during installation phase. The same configuration applies to OLM and non OLM installation.

Release Note

feat(operator): toleration install flag

@heiko-braun
Copy link

Is this an install time setting or can it be changed after the fact?

@squakez
Copy link
Contributor Author

squakez commented Mar 11, 2021

Is this an install time setting or can it be changed after the fact?

It will influence the operator Deployment spec adding a list of Tolerations. Once installed, if you want to change that you will need to do update the Deployment spec, probably manually, and reschedule the operator pods.

@heiko-braun
Copy link

Thanks for the clarification @squakez

@astefanutti
Copy link
Member

@squakez what would you think of applying the others customizers from the operator Deployment, like the monitoring port, to the CSV as well? I think you've almost done all the work with that PR, and it would avoid having some asymmetric options.

@squakez
Copy link
Contributor Author

squakez commented Mar 12, 2021

@squakez what would you think of applying the others customizers from the operator Deployment, like the monitoring port, to the CSV as well? I think you've almost done all the work with that PR, and it would avoid having some asymmetric options.

Yeah, I have in mind to add NodeSelector as well. I can create an issue to keep track of all of them.

astefanutti
astefanutti approved these changes Mar 12, 2021
View reviewed changes
pkg/util/kubernetes/util.go Outdated Show resolved Hide resolved
@squakez squakez force-pushed the feat/toleration_operator branch 3 times, most recently from e77c5c3 to f3a36e4 Compare March 22, 2021 13:51
@squakez
feat(operator): toleration install flag
7a6c4ac 
* Refactored toleration trait to create Tolerations in a util method
* Refactored OperatorOrCollect method to ease readability
* Added toleration configuration in OLM and non OLM installations
@squakez
refactor(util): k8s helper methods
5995f81
@squakez squakez force-pushed the feat/toleration_operator branch 2 times, most recently from c4e591e to 573e4c5 Compare March 26, 2021 10:04
@squakez
feat(operator): revert OperatorOrCollect
8b03f7d 
Reverted from c407bbd885c82d23d4baab48f8c59e946a7201fd change
@astefanutti astefanutti merged commit cb19602 into apache:master Mar 26, 2021
@astefanutti
Copy link
Member

Thanks!

@nicolaferraro nicolaferraro mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@squakez @heiko-braun @astefanutti