Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buildah to ensure it works with insecure registries #2138

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented Mar 16, 2021

Fix issue #2137 by reprioritizing the insecure flag check

Release Note

fix buildah strategy with mixed secure/insecure registries

pkg/trait/builder.go Outdated Show resolved Hide resolved
@orpiske orpiske changed the title fix: change prioritization of the insecure flag check to ensure it works with mixed secure/insecure registries fix: buildah to ensure it works with insecure registries Mar 16, 2021
@orpiske
Copy link
Contributor Author

orpiske commented Mar 16, 2021

FYI, I adjusted the topic because it is not re-prioritizing the insecure check anymore and, therefore, would be confusing.

@astefanutti
Copy link
Member

Let's merge this. Yaks tests errors are unrelated.

@astefanutti astefanutti merged commit ba57db3 into apache:master Mar 17, 2021
@astefanutti
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants