Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toleration trait e2e test #2142

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Mar 17, 2021

xref: https://issues.redhat.com/browse/ENTESB-15832

Release Note

e2e test coverage for toleration trait

@astefanutti
Copy link
Member

I created https://github.com/apache/camel-k/pull/2123/files#diff-c5088002fef267f74c89b31c5472e9782c2cca9dc3e2e1b354c85d9553b1a042 few days ago.

I've tried to cover a real use, rather than artificial ones, that are already covered by unit tests. However this proves bit challenging as this requires a mutli-nodes cluster. I'm happy to drop my changes in favour of this version.

@tplevko
Copy link
Contributor Author

tplevko commented Mar 17, 2021

@astefanutti I agree that this version might feel a bit artificial and the test you provided corresponds more with the e2e testsuite objective. I think it will be better to go with your changes and we can close this one.

@tplevko
Copy link
Contributor Author

tplevko commented Mar 17, 2021

@astefanutti also there is also one more option - I can add these tests to the one you added. To increase the coverage. WDYT?

@astefanutti
Copy link
Member

@tplevko that's a good idea 👍🏼. We can merge your PR since it's ready, and I'll merge mine into it. Does that work for you?

@tplevko
Copy link
Contributor Author

tplevko commented Mar 17, 2021

@astefanutti sounds good to me!

@astefanutti
Copy link
Member

@tplevko thanks. Let me merge it. Yaks tests errors are unrelated.

@astefanutti astefanutti merged commit e53faa8 into apache:master Mar 17, 2021
@astefanutti
Copy link
Member

Thanks.

@nicolaferraro nicolaferraro mentioned this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants