feat(operator): NodeSelector install options #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@astefanutti as you were involved in a similar PR for tolerations, would you mind having a look at this? Thanks! |
|
@squakez could you please rebase? |
Adding a factory to simplify creation of NodeSelectors and related unit tests
Adding a flag to allow defining any NodeSelector during regular installation procedure
Adding a flag to allow defining any NodeSelector during OLM installation procedure
squakez
force-pushed
the
feat/nodeselector_operator
branch
from
cbf43a1
to
3c5570d
Compare
astefanutti
approved these changes
Apr 12, 2021
|
Should be good to go now, thanks! |
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we give the user the possibility to chose a
Node Selectorwhen installing the operator, both for regular andolmmodes.Release Note